Enhance CMake testing in CI #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To not inflate the build matrix too much, just use the default settings; we mostly need this to test the CMake flow, not to test the actual code.
To reduce build time impact we just do a quick smoke test (configure & build).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now test CMake for Linux/macOS on GHA, and test it for all supported VS versions on AppVeyor (previously CMake was only exercised in GHA on Windows).
To reduce the impact on AppVeyor build time we only run a quick library build without actually compiling or running tests. This can be expanded in the future if need be.