Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.14.0 #101

Merged
merged 3 commits into from
Oct 1, 2021
Merged

Release 1.14.0 #101

merged 3 commits into from
Oct 1, 2021

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Sep 10, 2021 •
edited by falkenhawk
Loading

Prepare release using #92

Replaces #93

@glensc glensc mentioned this pull request Sep 10, 2021
Closed
@falkenhawk
Copy link
Member

thank you @glensc I can take care of the release (and possibly merging other PRs) today. Would you mind changing the version to 1.14.0-beta.1 please?

@falkenhawk
Copy link
Member

Hmm we still have a fatal error on php 8.0
PHP Fatal error: Uncaught ValueError: PDOStatement::setFetchMode(): Argument #1 ($mode) must be a bitmask of PDO::FETCH_* constants in /home/runner/work/zf1/zf1/packages/zend-db/library/Zend/Db/Statement/Pdo.php:433

but it's a weird and complex issue from what I see - #85

@glensc
Copy link
Contributor Author

glensc commented Sep 10, 2021 •
edited
Loading

@falkenhawk please continue yourself in this PR (add more commits). just don't lose my efforts.

also, don't forget to add new PRs your merged today to the changelog.

@falkenhawk falkenhawk changed the title Release 1.14.0 Release 1.14.0-beta Sep 10, 2021
@glensc
Copy link
Contributor Author

glensc commented Sep 10, 2021 •
edited
Loading

"^1.14.0-beta" is a valid semver, right? are you able to test this before actual push of the tags?

and shouldn't it be "^1.14.0-beta.1" as you wrote in the changelog? or you intentionally target "^1.14.0-beta.*"?

@falkenhawk falkenhawk changed the title Release 1.14.0-beta Release 1.14.0 Oct 1, 2021
@falkenhawk falkenhawk self-requested a review October 1, 2021 14:45
@falkenhawk falkenhawk merged commit b87db37 into zf1s:master Oct 1, 2021
@glensc glensc deleted the release-1.14.0 branch October 3, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falkenhawk falkenhawk falkenhawk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glensc @falkenhawk