Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zend-validate] Update list of available tlds #104

Merged
merged 3 commits into from
Oct 4, 2022

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Sep 10, 2021

@glensc glensc mentioned this pull request Sep 10, 2021
@glensc glensc changed the title Update list of available tlds [zend-validate] Update list of available tlds Sep 10, 2021
@falkenhawk
Copy link
Member

falkenhawk commented Sep 10, 2021

I tried to update the list by hand from the most recent version of https://data.iana.org/TLD/tlds-alpha-by-domain.txt, but noticed that some domains are not listed there i.a. aigo, caseih, intel etc. but they are still listed in http://www.iana.org/domains/root/db/ 🤔 Also, the txt list contains puny-encoded domains, whereas the web list has them listed in utf8 chars. So $_validTlds contains both :/

I looked up how they had it in the last zf version, and yes there was a script https://github.com/zendframework/zend-validator/blob/master/bin/update_hostname_validator.php - but it was using only the txt version but utf8 entries still existed in the $validTlds array of the validator so they were left there for BC probably and forgotten 🙈

The script was initially made to parse the web version in zendframework/zendframework@da354d6 but then modified at the same day to use the txt version instead zendframework/zendframework@3c1f8d8

@falkenhawk
Copy link
Member

I updated the list from the current txt version and decided not to remove any existing entries (which were probably copied from the web version initially) to keep backwards compatibility.

@glensc
Copy link
Contributor Author

glensc commented Sep 10, 2021

@falkenhawk don't merge any of these "new" PR's before you make 1.14.0 release

@glensc
Copy link
Contributor Author

glensc commented Sep 20, 2022

1.14.0 is released, so that blocker no longer applies.

SanderVanLeeuwen and others added 3 commits October 4, 2022 12:30
Based on https://data.iana.org/TLD/tlds-alpha-by-domain.txt

Signed-off-by: Elan Ruusamäe <glen@pld-linux.org>
to Version 2021090900, Last Updated Thu Sep  9 07:07:01 2021 UTC
and do not remove previously listed domains (originally copied from http://www.iana.org/domains/root/db) for BC
to Version 2022100300, Last Updated Mon Oct  3 07:07:01 2022 UTC

Deleted only those which were added in previous commit, as not relevant anymore (as that list was not released). Existing entries should not be deleted in any future updates.
@falkenhawk falkenhawk merged commit 95be8a1 into zf1s:master Oct 4, 2022
@falkenhawk falkenhawk mentioned this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants