Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zend Search Lucene PHP 7.4 compatibility #19

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

marcing
Copy link
Contributor

@marcing marcing commented Dec 17, 2019

Fix for issue: "Trying to access array offset on value of type int"

Copy link
Member

@falkenhawk falkenhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@falkenhawk falkenhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on second thought, it should be rather fixed in

instead. Term's text is expected to be always a string, and it should be casted there. This seems to be a workaround for manually constructed search terms with passed integers instead of strings.

@marcing marcing force-pushed the fix/zend-search-lucene-php74-compat branch from 949d204 to 4ad13de Compare December 18, 2019 20:24
@falkenhawk falkenhawk merged commit 787d5b2 into master Dec 18, 2019
@falkenhawk falkenhawk deleted the fix/zend-search-lucene-php74-compat branch December 18, 2019 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants