[zend-controller] fixes "Creation of dynamic property ::$ajaxable is deprecated" on PHP 8.2+ when using ContextSwitch helper
#196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falkenhawk
changed the title
ContextSwitch helper
marcing
force-pushed
the
fix/php8-zend-controller-action-contexts
branch
from
ae765c3
to
ea3c37e
Compare
falkenhawk
reviewed
Mar 13, 2024
| @@ -159,6 +159,25 @@ public function tearDown() | |||
| unset($_SERVER['HTTP_X_REQUESTED_WITH']); | |||
| } | |||
| } | |||
|
|
|||
| public function testAddActionContext() | |||
There was a problem hiding this comment.
This test doesn't actually test ajaxContext which would use ajaxable property in action controller, does it?
Also, indentation looks off
There was a problem hiding this comment.
Ok I understand now. The test uses $this->helper, which is instance of Zend_Controller_Action_Helper_AjaxContext over custom Zend_Controller_Action_Helper_AjaxContextTestController without contexts defined, then calls addActionContext to add new context to Zend_Controller_Action_Helper_AjaxContextTestController::$ajaxable.
falkenhawk
reviewed
Mar 13, 2024
marcing
force-pushed
the
fix/php8-zend-controller-action-contexts
branch
from
ea3c37e
to
ab64d58
Compare
…deprecated" on PHP 8.2+ when using ContextSwitch helper
marcing
force-pushed
the
fix/php8-zend-controller-action-contexts
branch
from
ab64d58
to
704fb68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup to #170 - unfinished fix for dynamic contexts in Zend_Controller_Action
fixes "Creation of dynamic property ::$ajaxable is deprecated" on PHP 8.2+ when using
ContextSwitchhelper