Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move MySQL testing from Travis to GitHub Actions #49

Merged
merged 4 commits into from
Mar 13, 2021

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Jan 28, 2021

Re-created from changes of #34

This PR moves MySQL related tests from Travis CI to GitHub Actions.

@glensc glensc force-pushed the ci-mysql branch 2 times, most recently from 580e941 to 00df9c7 Compare February 8, 2021 16:08
@glensc glensc marked this pull request as ready for review February 8, 2021 16:32
services:
memcache:
image: memcached:1-alpine
ports:
- 11211:11211

mysql:
image: mysql/mysql-server:5.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we have 5.7?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I just wanted to test with the lowest version available. ideally should add matrix of supported versions.

.github/workflows/tests.yml Outdated Show resolved Hide resolved
@glensc glensc marked this pull request as ready for review March 13, 2021 09:00
@glensc
Copy link
Contributor Author

glensc commented Mar 13, 2021

I don't have a recollection, and here's no note, why ready for review as removed, removed Draft state again.

@staabm
Copy link
Contributor

staabm commented Mar 13, 2021

fyi, for php 5.x/7.0 you should use a older ubuntu version, in case you want a faster github action.

see shivammathur/setup-php#63 (comment)

@glensc
Copy link
Contributor Author

glensc commented Mar 13, 2021

@staabm we're in a (very slow) proccess of using build-php for php5 (and possibly php7 in the future):

@falkenhawk falkenhawk merged commit 32076fc into zf1s:master Mar 13, 2021
@glensc glensc mentioned this pull request Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants