Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paginator: fixed phpdoc typo #86

Merged
merged 2 commits into from
Mar 23, 2021
Merged

paginator: fixed phpdoc typo #86

merged 2 commits into from
Mar 23, 2021

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Mar 15, 2021

$this->_createPages($scrollingStyle); returns a stdClass so getPages can never return a array as documented

`$this->_createPages($scrollingStyle);` returns a `stdClass` so `getPages` can never return a array as documented
Copy link
Member

@falkenhawk falkenhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also fix the type at

while you are at it, please? 🙏

@staabm
Copy link
Contributor Author

staabm commented Mar 15, 2021

Could you also fix the type at

good catch. Sure thing

@falkenhawk
Copy link
Member

Thank you for your contribution @staabm!

@falkenhawk falkenhawk merged commit 82e23ed into zf1s:master Mar 23, 2021
@staabm staabm deleted the patch-1 branch March 23, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants