This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Hotfix - saving and retrieving authorization data (REST and RPC) #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @webimpress ! |
This was referenced Aug 16, 2016
|
@jguittard Please do the following as well:
|
|
Will do, thx for the reminder! |
| @@ -448,11 +450,13 @@ | |||
| }; | |||
|
|
|||
| this.getAuthorizationRpc = function(module, version, name, callback) { | |||
| var moduleParam = this.normalizeModuleName(module); | |||
| var moduleParam = this.normalizeModuleName(module), | |||
| controllerName = name.replace(/-/g, '\\'), | |||
There was a problem hiding this comment.
The backend understands both - and \\ as separation characters within the controller service names, so this normalization isn't strictly necessary.
weierophinney
added a commit
that referenced
this pull request
Aug 17, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue reported in #126 and #127