This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Improve services loading responsiveness (sidebar) #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saulotoledo
force-pushed
the
improve_sidebar_responsiveness
branch
from
f2e52d8
to
6e8d238
Compare
|
Hi @weierophinney. Let me know if you prefer the solution with one loader than having the order of the services changing as commented above. In the first case the API returns the list ordered by name. We cannot predict the order of the services in the first time. How do you handle the dist folder in the project? I see that you have a compiled version in the repository. |
michalbundyra
added a commit
that referenced
this pull request
Nov 24, 2019
Improve services loading responsiveness (sidebar)
michalbundyra
added a commit
that referenced
this pull request
Nov 24, 2019
|
Thanks, @saulotoledo! More fixes like that are very welcome! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #152 by adding loaders to the services.
Please note that the order of the services changes after the data is fully loaded. That happens because the data returned by the backend have a different order. The default behavior in the UI is to track the data by using the same order returned by the backend. We could hide this by adding a single loader for all services instead. However, this PR does not intent to change such behavior.
The image below shows the fix: