This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
#297 Patch's data can't be changed by listener fix #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalbundyra
approved these changes
Sep 5, 2017
There was a problem hiding this comment.
I can see you update the patch method exactly as we have updated the others. I think it's good, and it should be there.
It would be nice to add some tests to demonstrate that it works as expected, but then we have to do the same also for other methods. I have a look also on other methods, and there is a big mess with data passed to the event. Definitely we need a bit more work on it, to fix it all.
michalbundyra
added a commit
that referenced
this pull request
Jan 17, 2018
#297 Patch's data can't be changed by listener fix
michalbundyra
added a commit
that referenced
this pull request
Jan 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.