This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Remove the development cache file on all actions #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switching from development mode and back should always remove the application configuration cache file to ensure that changes are propagated properly. Discovered when configuration cache files were accidently included in an Apigility skeleton app, where the last action performed was to enable development mode!
|
Reviewed. Looks good to me. |
Now you do. :) |
akrabat
added a commit
that referenced
this pull request
Aug 5, 2015
…ways Remove the development cache file on all actions
akrabat
added a commit
that referenced
this pull request
Aug 5, 2015
akrabat
added a commit
that referenced
this pull request
Aug 5, 2015
|
About the review, it has been done too fast. config_cache_key and cache_dir keys are both part of the module_listener_options configuration container. Here, you try to get them from the first config level. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching from development mode and back should always remove the application configuration cache file to ensure that changes are propagated properly.
Discovered when configuration cache files were accidently included in an Apigility skeleton app, where the last action performed was to enable development mode!