This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Add auto_composer command. #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmiklautz
force-pushed
the
auto_composer
branch
from
356a5bc
to
3ba01b6
Compare
weierophinney
approved these changes
May 7, 2018
There was a problem hiding this comment.
Overall, this looks like a nice addition. I'll take care of the changes for which I left feedback during merge.
Thanks, @bmiklautz !
src/Auto.php
Outdated
| /** | ||
| * @var value of COMPOSER_DEV_MODE | ||
| */ | ||
| private $composer_dev_mode; |
There was a problem hiding this comment.
Please use camelCase for property names.
src/Auto.php
Outdated
| } | ||
| } | ||
| // not running under composer | ||
| echo 'COMPOSER_DEV_MODE not set. Nothing to do.' . PHP_EOL; |
There was a problem hiding this comment.
Please invert the statements, so that we can return early. As an example:
if ($this->composerDevMode === '') {
echo 'COMPOSER_DEV_MODE not set; nothing to do.' . PHP_EOL;
return 0;
}
if ($this->composerDevMode === '0') {
$disable = $this->projectDir, $this->errorStream);
return $disable();
}
$enable = new Enable($this->projectDir, $this->errorStream);
return $enable;Changes like this make it easier to determine the various behaviors, boiling this one down to exactly three.
src/Command.php
Outdated
| @@ -42,6 +42,9 @@ public function __invoke(array $arguments) | |||
| case 'status': | |||
| $status = new Status(); | |||
| return $status(); | |||
| case 'auto_composer': | |||
There was a problem hiding this comment.
We typically use dash-separated names, so this should become auto-composer.
src/Auto.php
Outdated
|
|
||
| namespace ZF\DevelopmentMode; | ||
|
|
||
| class Auto |
There was a problem hiding this comment.
We should rename this class to mimic the command itself: AutoComposer.
When auto_composer is used development mode is set based on the
environment Variable COMPOSER_DEV_MODE. If it's undefined the mode
isn't touched. If its anything else then 0 developer mode is enabled.
This can be used as post-[install|update]-cmd for composer to enable
development mode based on the mode composer was called with (--dev vs. --no-dev):
...
"scripts": {
"development-auto": "zf-development-mode auto_composer",
"post-install-cmd": ["@development-auto" ],
"post-update-cmd": [ "@development-auto" ],
}
...
* move functionality to an extra class * add the corresponding tests
- Renames class to `AutoComposer` - Renames command to `auto-composer` - Rewrites `AutoComposer::__invoke()` to do a conditional per behavior, with each returning. In doing so, identified an issue with how it detected absence of a `COMPOSER_DEV_MODE` value, as well as inability to correctly report an invalid value was provided.
weierophinney
force-pushed
the
auto_composer
branch
from
3ba01b6
to
4032492
Compare
weierophinney
added a commit
that referenced
this pull request
May 7, 2018
weierophinney
added a commit
that referenced
this pull request
May 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When auto_composer is used development mode is set based on the
environment Variable COMPOSER_DEV_MODE. If it's undefined the mode
isn't touched. If its anything else then 0 developer mode is enabled.
This can be used as post-[install|update]-cmd for composer to enable
development mode based on the mode composer was called with (--dev vs. --no-dev):
...
"scripts": {
"development-auto": "zf-development-mode auto_composer",
"post-install-cmd": ["@development-auto" ],
"post-update-cmd": [ "@development-auto" ],
}
...