Fix "last step wins" error #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whether the job fails or not was being overwritten by the last step in the job. If the last step is pinned, this would cause the check to pass, even if an earlier step was unpinned. Now we have a test case that exercises this functionality.
Previously this logic only failed the job if the last step had an error.
wadells
force-pushed
the
fix-last-action-wins
branch
from
730c7d4 to
751aec5
Compare
|
Thank you so much for contributing this fix! 🚀 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #133, a regression introduced in #127.
Specifically: when a job had multiple steps, the
runAssertionscheck on the last step overwrote thejobHasErrorvalue from all previous steps. This will cause the following job to pass, even though the initialactions/checkoutis unpinned.Testing
I added a job to the
unpinnedstubs that simulates the above workflow. I don't have javascript/jest setup locally, so I'm counting on CI to let me know if I'm missing anything. You're welcome to edit this PR (or close it and do it a better way) if this isn't a suitable fix.