[sonic-head.yang]: Libyang sweep host bits from inet:ip-prefix, fixin… #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g that problem. Changed inet:ip-prefix to custom ip-prefix. Changed test case accordingly.
|
Should we do the same for loopback interface too? |
zhenggen-xu
reviewed
Mar 2, 2020
| @@ -52,22 +52,37 @@ module: sonic-acl | |||
| module: sonic-interface | |||
There was a problem hiding this comment.
Is file autogenerated? If so, should we not keep this as part of the code?
There was a problem hiding this comment.
This file is generated by Pyang tool. Yes, Cool, we can also generate it as part of build process. Sonic-stretch docker will\should have pyang installed and then while building sonic-yang-models pkg I can run "pyang" tool.
Yes, I missed loopback interface, I need to fix it for loopback as well. |
Changes done: 1.) Build yang tree while package build. 2.) Add sonic_yang_tree as part of package. 3.) Fix sonic-loopback-interface.yang for ip-prefix problem.
zhenggen-xu
approved these changes
Mar 4, 2020
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Apr 23, 2020
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Aug 9, 2022
…w components mgmt. (sonic-net#10377) * Support new platform SN2201 and RJ45 port Signed-off-by: Kebo Liu <kebol@nvidia.com> * remove unused import and redundant function Signed-off-by: Kebo Liu <kebol@nvidia.com> * fix error introduced by rebase Signed-off-by: Kebo Liu <kebol@nvidia.com> * Revert the special handling of RJ45 ports (zhenggen-xu#56) * Revert the special handling of RJ45 ports sfp.py sfp_event.py chassis.py Signed-off-by: Stephen Sun <stephens@nvidia.com> * Remove deadcode Signed-off-by: Stephen Sun <stephens@nvidia.com> * Support CPLD update for SN2201 A new class is introduced, deriving from ComponentCPLD and overloading _install_firmware Change _install_firmware from private (starting with __) to protected, making it overloadable Signed-off-by: Stephen Sun <stephens@nvidia.com> * Initialize component BIOS/CPLD Signed-off-by: Stephen Sun <stephens@nvidia.com> * Remove swb_amb which doesn't on DVT board any more Signed-off-by: Stephen Sun <stephens@nvidia.com> * Remove the unexisted sensor - switch board ambient - from platform.json Signed-off-by: Stephen Sun <stephens@nvidia.com> * Do not report error on receiving unknown status on RJ45 ports Translate it to disconnect for RJ45 ports Report error for xSFP ports Signed-off-by: Stephen Sun <stephens@nvidia.com> * Add reinit for RJ45 to avoid exception Signed-off-by: Stephen Sun <stephens@nvidia.com> Co-authored-by: Stephen Sun <5379172+stephenxs@users.noreply.github.com> Co-authored-by: Stephen Sun <stephens@nvidia.com>
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Aug 9, 2022
3f43852b8 [sonic_operators.cpp]: Increasing select timeout (zhenggen-xu#55) a1142e251 [sonic_operators.cpp] Update sonic_db_manager::get_counter (zhenggen-xu#56) 1069d2dd4 [sonic_operators.cpp]: Fixbug wait with false positive to return success (zhenggen-xu#54) Signed-off-by: Ze Gan <ganze718@gmail.com>
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Dec 23, 2022
[sonic-linkmgrd][202012] submodule update 3523738 Jing Zhang Sun Apr 3 20:54:40 2022 -0700 Reset link prober state when default route is back zhenggen-xu#56 8282e78 Jing Zhang Fri Apr 15 15:59:34 2022 -0700 Keep incrementing sequence number when link prober is suspended and shutdown zhenggen-xu#55 (zhenggen-xu#65) 8246eb8 Jing Zhang Thu Apr 14 18:49:36 2022 -0700 Shutdown ICMP heartbeats when default route state is missing and ToR is in auto mode zhenggen-xu#44 (zhenggen-xu#59) sign-off: Jing Zhang zhangjing@microsoft.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g that problem.
Changed inet:ip-prefix to custom ip-prefix.
Changed test case accordingly.
- What I did
Libyang sweep host bits from inet:ip-prefix, fixing that problem.
- How I did it
Changed inet:ip-prefix to custom ip-prefix.
Changed test case accordingly.
- How to verify it
Build the package and also wrote custom test case to print config diff.
Testing for Commit 2:
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)