forked from sonic-net/sonic-buildimage
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle port deletion while updating lldp #66
Merged
zhenggen-xu
merged 1 commit into
zhenggen-xu:sonic-cfg-mgmt
from
vasant17:SYS_LOG_LLDP_ERR_FIX
Apr 14, 2020
Merged
Handle port deletion while updating lldp #66
zhenggen-xu
merged 1 commit into
zhenggen-xu:sonic-cfg-mgmt
from
vasant17:SYS_LOG_LLDP_ERR_FIX
Apr 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenggen-xu
reviewed
Apr 9, 2020
zhenggen-xu
approved these changes
Apr 14, 2020
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Aug 12, 2020
) **sonic-platform-common:** Commits on Jul 07, 2020 Changes in fan and psu base classes (1.0 platform API) related to pdd… 17292e4 Commits on Jul 10, 2020 update get_pcie_check() to use sysfs instead of lspci output (zhenggen-xu#95) d4eb804 Commits on Jul 11, 2020 [eeprom] Fix UnboundLocalError (zhenggen-xu#93) 7c8bed1 Commits on Jul 14, 2020 [Transceiver] Add parser for QSFP-DD cable type and dictionaries for … be1cc24 **sonic-platform-daemons:** Commits on Jul 06, 2020 [psud] Store PSU temperature and voltage information to database (zhenggen-xu#61) ef9716a Commits on Jul 14, 2020 [xcvrd] Add support for QSFP-DD cables (zhenggen-xu#66) c530587 Commits on Jul 18, 2020 Initial version of pcied (zhenggen-xu#60) e665ee8 [xcvrd] Return non-zero error code on SFP error (zhenggen-xu#67) 4f42a79 Commits on Jul 19, 2020 [README.md] Add LTGM badges (zhenggen-xu#69) 23757a3 Remove unused imports (zhenggen-xu#70) 029d5a5 Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
zhenggen-xu
pushed a commit
that referenced
this pull request
Aug 31, 2020
[configdb.py]: Allow deletion of entire table from mod_config API. (#61) [MultiDB] mimic redis-dump-load , adding sonic_db_dump_load.py and so… [MultiDB] add sonic-db-cli PING all instances support (#65) Fix sonic-db-cli script to be compatible with python3 and python2.7 (#66) Namespace support in SonicV2Connector (#63) [Multiasic]: Add calculation of interface index for backplane interfa…
zhenggen-xu
pushed a commit
that referenced
this pull request
Aug 31, 2020
[xcvrd] Add support for QSFP-DD cables (#66)
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Jan 16, 2021
b002455 - 2020-12-16 : Validate IP only if nexthop attribute is not null (zhenggen-xu#66) [Prince Sunny] 76592a9 - 2020-12-03 : Add License file (zhenggen-xu#62) [Prince Sunny]
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Apr 27, 2021
1c3f75e (HEAD -> master, origin/master, origin/HEAD) pindown the version of github.com/openconfig/gnoi (zhenggen-xu#76) 33acd5b [ci]: setup proper azp (zhenggen-xu#75) 5d82051 [CI] Set up CI with Azure Pipelines (zhenggen-xu#72) 0688cdb Remove go get commands from Makefile to prevent go.mod file from chan… (zhenggen-xu#66)
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Jul 28, 2021
1c3f75e (HEAD -> master, origin/master, origin/HEAD) pindown the version of github.com/openconfig/gnoi (zhenggen-xu#76) 33acd5b [ci]: setup proper azp (zhenggen-xu#75) 5d82051 [CI] Set up CI with Azure Pipelines (zhenggen-xu#72) 0688cdb Remove go get commands from Makefile to prevent go.mod file from chan… (zhenggen-xu#66)
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Feb 15, 2022
1c3f75e (HEAD -> master, origin/master, origin/HEAD) pindown the version of github.com/openconfig/gnoi (zhenggen-xu#76) 33acd5b [ci]: setup proper azp (zhenggen-xu#75) 5d82051 [CI] Set up CI with Azure Pipelines (zhenggen-xu#72) 0688cdb Remove go get commands from Makefile to prevent go.mod file from chan… (zhenggen-xu#66)
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Dec 23, 2022
[sonic-linkmgrd][202012] submodule update 3d13ff2 Jing Zhang Wed May 4 10:07:14 2022 -0700 Add doc for default route related changes (zhenggen-xu#63) c703be4 Jing Zhang Mon May 2 13:27:54 2022 -0700 Reset WaitActiveUp count before switching to active (zhenggen-xu#70) 86eb727 Jing Zhang Wed Apr 27 10:35:05 2022 -0700 lower log level to warning (zhenggen-xu#69) e22c736 Jing Zhang Mon May 2 13:33:24 2022 -0700 [202012] Avoid proactively switching to active if default route is missing (zhenggen-xu#67) d4f282b Jing Zhang Thu Apr 28 18:35:11 2022 -0700 [202012] Add support to enable switchover time measurement (with link prober interval decreased to 10ms) feature (zhenggen-xu#66) sign-off: Jing Zhang [zhangjing@microsoft.com](mailto:zhangjing@microsoft.com)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Handled port deletion in lldpmgrd.
- How I did it
During dynamic port breakoput, we delete and add a port. When we delete a port, the port may NOT be present in one or both DBs (CFG and APP).
The goal is to configure the lldp when the port is present in both DBs and it has at-least alias or description set and the port is in oper_status UP.
- How to verify it
By running DPB command and checking the syslog messages
Before fix following error messages were seen in syslog:
After fix the error messages were NOT seen.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)