Rework port dependency #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasant17
changed the title
vasant17
force-pushed
the
REWORK_PORT_DEPENDENCY
branch
from
07d3bb6
to
c459ae0
Compare
zhenggen-xu
reviewed
Feb 27, 2020
vasant17
force-pushed
the
REWORK_PORT_DEPENDENCY
branch
from
c459ae0
to
11463a1
Compare
zhenggen-xu
reviewed
Mar 2, 2020
vasant17
force-pushed
the
REWORK_PORT_DEPENDENCY
branch
from
0954b0c
to
784f6e5
Compare
zhenggen-xu
approved these changes
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Removed code to track port dependency in orchagent. Using SAI REDIS return code to see if port deletion failed due to port dependency
Why I did it
So, that we can rely on SAI REDIS code for dependency check instead of duplicating the effort in orchagent.
How I verified it
Ran DPB command via CLI, and verified in syslog that dependency is really caught and correct log messages are printed. Also verified that breakout itself goes through successfully when dependencies are removed.
Details if related