Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update C++ interfaces of TorchVision to 0.9.0+ #136

Merged
merged 4 commits into from
Jul 13, 2021
Merged

Update C++ interfaces of TorchVision to 0.9.0+ #136

merged 4 commits into from
Jul 13, 2021

Conversation

xiguadong
Copy link
Contributor

@xiguadong xiguadong commented Jul 13, 2021 •
edited by zhiqwang
Loading

Closes #134 , To resolve the libtorch version conflicts.

@CLAassistant
Copy link

CLAassistant commented Jul 13, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 13, 2021 •
edited
Loading

Codecov Report

Merging #136 (5c1b3cd) into master (82d6afb) will not change coverage.
The diff coverage is n/a.

❗ Current head 5c1b3cd differs from pull request most recent head 6720a6d. Consider uploading reports for the commit 6720a6d to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #136   +/-   ##
=======================================
  Coverage   83.56%   83.56%           
=======================================
  Files           8        8           
  Lines         779      779           
=======================================
  Hits          651      651           
  Misses        128      128
Flag Coverage Δ
unittests 83.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82d6afb...6720a6d. Read the comment docs.

@zhiqwang zhiqwang changed the title modify the development Update C++ interfaces of TorchVision to 0.9.0+ Jul 13, 2021
@zhiqwang zhiqwang added the enhancement New feature or request label Jul 13, 2021
@zhiqwang zhiqwang merged commit ec5464d into zhiqwang:master Jul 13, 2021
zhiqwang
zhiqwang approved these changes Jul 13, 2021
View reviewed changes
Copy link
Owner

@zhiqwang zhiqwang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contributions.

This was referenced Jul 13, 2021
Closed
Closed
@mattpopovich
Copy link
Contributor

Just circling back on this to confirm that this fix works and closes my issue #132 as well as #134.
I've tested it on pytorch 1.8.0 and torchvision 0.9.0.
Thank you!

@zhiqwang zhiqwang added the dependencies Pull requests that update a dependency file label Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqwang zhiqwang zhiqwang approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update libtorch interfaces of TorchVision to 0.9.0+
4 participants
@xiguadong @CLAassistant @mattpopovich @zhiqwang