fix: avoid matching prototype keys in special char map

zhlint-project · Aug 19, 2024 · b683362 · b683362
1 parent 64c5b5c
commit b683362
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/rules/punctuation-unification.ts b/src/rules/punctuation-unification.ts
@@ -96,14 +96,14 @@ const generateHandler = (options: Options): Handler => {
 
   const handlerPunctuationUnified = (token: MutableToken) => {
     if (token.type === GroupTokenType.GROUP) {
-      if (charMap[token.modifiedStartValue]) {
+      if (Object.prototype.hasOwnProperty.call(charMap, token.modifiedStartValue)) {
         checkStartValue(
           token,
           charMap[token.modifiedStartValue],
           PUNCTUATION_UNIFICATION
         )
       }
-      if (charMap[token.modifiedEndValue]) {
+      if (Object.prototype.hasOwnProperty.call(charMap, token.modifiedEndValue)) {
         checkEndValue(
           token,
           charMap[token.modifiedEndValue],
@@ -112,7 +112,7 @@ const generateHandler = (options: Options): Handler => {
       }
       return
     } else {
-      if (charMap[token.modifiedValue]) {
+      if (Object.prototype.hasOwnProperty.call(charMap, token.modifiedValue)) {
         checkValue(
           token,
           charMap[token.modifiedValue],

diff --git a/test/uncategorized.test.ts b/test/uncategorized.test.ts
@@ -182,4 +182,9 @@ import ApiIndex from './ApiIndex.vue'
 `
     expect(getOutput(text, options)).toBe(text)
   })
+  // https://github.com/zhlint-project/zhlint/issues/159
+  test('#159 unexpected function () { [native code] }', () => {
+    const text = `p.toString() 中文`
+    expect(getOutput(text, options)).toBe(text)
+  })
 })