Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed end2end test concept and testcases #510

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Conversation

andy-maier
Copy link
Member

@andy-maier andy-maier commented Apr 10, 2022

For details, see the commit message.

@andy-maier andy-maier self-assigned this Apr 10, 2022
@andy-maier andy-maier added this to the 1.1.0 milestone Apr 10, 2022
@andy-maier andy-maier linked an issue Apr 10, 2022 that may be closed by this pull request
@andy-maier andy-maier force-pushed the andy/fix-end2end-tests branch 2 times, most recently from 82a5d61 to 20bf589 Compare April 10, 2022 11:14
@coveralls
Copy link

coveralls commented Apr 10, 2022

Coverage Status

Coverage remained the same at 33.088% when pulling 08a9f86 on andy/fix-end2end-tests into 41d85cd on master.

Details:

* Test: Added missing env.vars in the pytest invocation for end2end tests.

* Test: Added support for specifying 'hmc_auth.ca_certs' and 'hmc_auth.verify'
  from the 'hmc_verify_cert' parameter in the HMC definition file in
  end2end test cases for zhmc_partition and zhmc_user.

* Test: Made end2end testing compatible with zhmcclient.testutils support for
  HMC definition files.
  The HMC definition file is now by default ~/.hmc_hmc_definitions.yaml, and
  the env.var to override that is now TESTHMCFILE.

* Test: Added support for a TESTCASES env.var for filtering testcases with the
  pytest -k option.

* Fixed incorrect assumption about defaulting of optional module parameters:
  This is only done automatically when the module is invoked by ansible,
  but not when invoked by the end2end testcases. Changed the end2end testcases
  for zhmc_partition and zhmc_user to specify the optional parameters.

* Changed picking of partition to test in end2end testcase
  test_partition_facts() to be a random partition of each type.

Signed-off-by: Andreas Maier <maiera@de.ibm.com>
@vkathir82 vkathir82 merged commit 873349d into master Apr 11, 2022
@vkathir82 vkathir82 deleted the andy/fix-end2end-tests branch April 11, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants