update log level setting, close #44 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
zhongwencool
approved these changes
Feb 13, 2017
secretworry
reviewed
Feb 13, 2017
| end | ||
|
|
||
| def call(request_env, next_fn, level) do | ||
| def call(request_env, next_fn, options) do |
There was a problem hiding this comment.
We should move message formatting logic into a separate method, so we can implment the call function more concisely.
start_time = :erlang.system_time :micro_seconds
next_fn.(request_env) |> log_request(start_time, options)There was a problem hiding this comment.
I think call function is concisely enough, if you still think there're too many logic into it, we can make another pr to fix it.
that's how plug do time format https://github.com/elixir-lang/plug/blob/master/lib/plug/logger.ex#L45-L46
lib/maxwell/middleware/logger.ex
Outdated
| end | ||
|
|
||
| def call(request_env, next_fn, level) do | ||
| def call(request_env, next_fn, options) do | ||
| start_time = :os.timestamp() | ||
| new_result = next_fn.(request_env) | ||
| method = request_env.method |> to_string |> String.upcase | ||
| case new_result do | ||
| {:error, reason, _conn} -> | ||
| error_reason = to_string(:io_lib.format("~p", [reason])) |
There was a problem hiding this comment.
I just wonder, why not to use inspect here.
lib/maxwell/middleware/logger.ex
Outdated
| end | ||
|
|
||
| unless is_nil(color) do |
There was a problem hiding this comment.
I know is_nil(color) is equal to is_nil(level), but the later one would be more straitforward.
3 similar comments
1 similar comment
secretworry
approved these changes
Feb 13, 2017
|
Thanks for the PR!! 👏 🎊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.