Allow query strings to have nested params and arrays. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 similar comments
|
@zhongwencool there are 6 failing ibrowse and httpc adapter tests that were failing on a clean clone from master. My changes shouldn't have changed anything to do with them... Can you take a look when you have a chance? |
|
That's great! |
3 similar comments
|
@zhongwencool I noticed some coverage was missing from the Query module, so I also added the tests from Plug, but it seems those tests aren't running when you do |
|
The test file needs to be named |
|
Oh, derp! I feel silly now... |
3 similar comments
|
Thanks @doughsay :0 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, maxwell can't make requests to servers that allow arrays and nested params in query strings. Phoenix and Rails servers (for example) all support this kind of query string, so not being able to make these kinds of requests is a big blocker for some use-cases.
To implement this, I've copied the query string encoding/decoding module from Plug, because there is no other package currently available that has this functionality. I've opened an issue with the Plug team about it and they are ok with copy-pasting for now. (elixir-plug/plug#539)
Let me know what you think!
(also, use ?w=1 to see the important changes, since I fixed a few unrelated whitespace issues.)