Skip to content

isisd: (test2)When the metric-type is configured as "wide" #181

isisd: (test2)When the metric-type is configured as "wide"

isisd: (test2)When the metric-type is configured as "wide" #181

Triggered via pull request August 26, 2024 06:52
@zhou-runzhou-run
synchronize #11
202407301436
Status Failure
Total duration 35s
Artifacts

commitlint.yml

on: pull_request
Check if the commits meet the requirements of the guidelines
26s
Check if the commits meet the requirements of the guidelines
Fit to window
Zoom out
Zoom in

Annotations

1 error and 1 warning
Check if the commits meet the requirements of the guidelines
You have commit messages with errors ⧗ input: isisd: When the metric-type is configured as "wide", the IS-IS generates incorrect metric values for IPv4 directly connected routes. The IPv4 directly connected route prefix exists in both the root LSP and the root's neighbor LSP: When generating vertices for directly connected route prefixes with a metric of 0 based on the root LSP, the isis_spf_preload_tent_ip_reach_cb function only generates vertices of type VTYPE_IPREACH_INTERNAL without distinguishing between area->oldmetric and area->newmetric. When generating vertices for the directly connected route prefix based on the neighbor LSP, the isis_spf_process_lsp function will generate vertices of type VTYPE_IPREACH_INTERNAL and VTYPE_IPREACH_TE based on area->oldmetric and area->newmetric, where the vertex metric is the sum of the metric from the root IS to the neighbor IS and from the neighbor IS to the root IS, respectively. If area->newmetric==1, the same directly connected route prefix will have both VTYPE_IPREACH_INTERNAL vertices with a metric of 0 and VTYPE_IPREACH_TE vertices with a non-zero metric. During route generation, the isis_spf_loop function will prioritize selecting VTYPE_IPREACH_TE vertices, leading to incorrect metrics for the directly connected routes. Supplement topotest modifications. Directly connected routes with incorrect ISIS cost calculations should not appear in the RIB. Signed-off-by: zhou-run <zhou.run@h3c.com> ✖ header must not be longer than 72 characters, current length is 132 [header-max-length] ✖ subject may not end with full stop [subject-full-stop] ✖ found 2 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
Check if the commits meet the requirements of the guidelines
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/