-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook rework for smoke tests #60
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #60 +/- ##
==========================================
+ Coverage 95.98% 96.01% +0.02%
==========================================
Files 44 44
Lines 3541 3541
==========================================
+ Hits 3399 3400 +1
+ Misses 142 141 -1
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Handled about half of the notebooks. Should decrease the testing time significantly but I could be wrong since I'm running on different hardware locally. Let's see how long it takes now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and the notebook test time has been reduced by a factor of 2
@ziatdinovmax great! Take a quick look at them too when you can too. I did make some QOL changes, made the plots a bit clearer, etc. |
Resolves #53.