Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain compatibility with 1.2 release of the API #610

Open
robszewczyk opened this issue Oct 15, 2024 · 4 comments
Open

Maintain compatibility with 1.2 release of the API #610

robszewczyk opened this issue Oct 15, 2024 · 4 comments
Milestone

Comments

@robszewczyk
Copy link

Problem

In generic APIs for getting certificates are expected to return the certificates from the DA PKI. To that end, in 1.2:

  • GET /dcl/pki/certificates returns a list of certificates
  • GET /dcl/pki/certificates/{subject} returns a list of certificates by subject
  • GET /dcl/pki/certificates/{subject}/{skid} returns a certificate for a subject and SKID

The crititical problem is that a 1.2 client would never look at the new fields added in Certificate.proto and thus not be aware that the returned values have different semantics.

Proposed resolution

  • the existing APIs for certificates continue to return certificates from the DA PKI with old semantics
  • we create a new set of endpoints e.g. certificates2 that have the semantics of getting all certificates
@hawk248
Copy link
Collaborator

hawk248 commented Oct 16, 2024

Reading DCL 1.2 docs, it clearly state Gets all certificates (root, intermediate and leaf). for /dcl/pki/certficates API.
It is meant to be generic common API dealing with all certificates.

Alternatively, the correct API for root (PAA) certs is /dcl/pki/root-certificates which ONLY returns PAA. The docs mention: Gets all approved root certificates. Revoked certificates are not returned. Use GET_ALL_REVOKED_X509_CERTS_ROOT to get a list of all revoked root certificates.

@hawk248
Copy link
Collaborator

hawk248 commented Oct 17, 2024

In DCL 1.2 -> /dcl/pki/root-certificates : Returns ONLY PAA.
In DCL 1.4 -> /dcl/pki/root-certificates : Returns ONLY PAA.
In DCL 1.4 -> /dcl/pki/noc-root-certificates : Returns ONLY RCAC.

@hawk248
Copy link
Collaborator

hawk248 commented Oct 17, 2024

Update /dcl/pki/certificates in 1.4 so that it will ONLY return PAA, PAI and DAC if PAI and DAC have been uploaded in device attestation chain.

Implement another API that returns certificates regardless of PKI chain e.g. inclusive of DA or NOC.

paa-certificates
rcac-certificates

@hawk248
Copy link
Collaborator

hawk248 commented Oct 31, 2024

Addressed as part of #612

@Artemkaaas Artemkaaas added this to the v1.4: DCL 1.4 milestone Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants