Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKI API compatibility #613

Merged
merged 27 commits into from
Nov 15, 2024
Merged

PKI API compatibility #613

merged 27 commits into from
Nov 15, 2024

Conversation

Artemkaaas
Copy link
Collaborator

@Artemkaaas Artemkaaas commented Nov 2, 2024

This PR is address to resolve the following issues connected to PKI API compatibility:

Changes:

  • Updated Certificate type definition: use CertificateType enum instead of isNoc boolean flag
  • Updated PKI API:
    • APIs returning ALL certificate types:
      • /dcl/pki/all-certificates
      • /dcl/pki/all-certificates/{subject}/{subjectKeyId}
      • /dcl/pki/child-certificates/{issuer}/{authorityKeyId}
    • APIs returning DA certificate types:
      • /dcl/pki/certificates
      • /dcl/pki/certificates/{subject}
      • /dcl/pki/certificates/{subject}/{subjectKeyId}
      • /dcl/pki/revoked-certificates/{subject}/{subjectKeyId}
      • /dcl/pki/revoked-certificates
      • /dcl/pki/root-certificates
      • /dcl/pki/revoked-root-certificates
    • APIs returning NOC certificate types:
      • /dcl/pki/all-noc-certificates
      • /dcl/pki/all-noc-certificates/{subject}
      • /dcl/pki/all-noc-certificates/{subject}/{subjectKeyId}
      • /dcl/pki/noc-certificates/{vid}/{subjectKeyId}
      • /dcl/pki/noc-root-certificates/{vid}
      • /dcl/pki/noc-root-certificates
      • /dcl/pki/noc-ica-certificates/{vid}
      • /dcl/pki/noc-ica-certificates
      • /dcl/pki/revoked-noc-root-certificates/{subject}/{subjectKeyId}
      • /dcl/pki/revoked-noc-root-certificates
      • /dcl/pki/revoked-noc-ica-certificates/{subject}/{subjectKeyId}
      • /dcl/pki/revoked-noc-ica-certificates

Artemkaaas and others added 4 commits October 31, 2024 15:13
Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>
Signed-off-by: Abdulbois <abdulbois123@gmail.com>
Signed-off-by: Abdulbois Tursunov <abdulbois.tursunov@dsr-corporation.com>
@Artemkaaas Artemkaaas force-pushed the pki-compatibility branch 4 times, most recently from 86c7f69 to fbf4f84 Compare November 5, 2024 12:24
@Artemkaaas Artemkaaas force-pushed the pki-compatibility branch 10 times, most recently from 01d39d1 to 85e8358 Compare November 6, 2024 10:44
README-DEV.md Outdated Show resolved Hide resolved
@Artemkaaas Artemkaaas force-pushed the pki-compatibility branch 6 times, most recently from 9d76e2f to e52510b Compare November 7, 2024 07:49
x/pki/keeper/child_certificates.go Show resolved Hide resolved
x/pki/keeper/msg_server_assign_vid.go Show resolved Hide resolved
x/pki/client/cli/query_certificates.go Outdated Show resolved Hide resolved
x/pki/client/cli/query_certificates.go Outdated Show resolved Hide resolved
x/pki/client/cli/query_noc_certificates.go Show resolved Hide resolved
x/pki/handler_test.go Show resolved Hide resolved
x/pki/handler_test.go Outdated Show resolved Hide resolved
@ashcherbakov ashcherbakov merged commit b495653 into master Nov 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants