#519 Query Certificates with subjectKeyId #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Abdulbois
commented
Jan 10, 2024
•
Abdulbois
commented
- Enable querying certs with subjectKeyId
- Add migration flow (pki module - from 2 to 3 version)
- Update OpenApi yaml file (includes missed changes from PID scoped Accounts #523)
Abdulbois
force-pushed
the
#519-Query-PAA-certificate-with-only-subjectKeyId
branch
30 times, most recently
from
74c1028
to
3a4dca7
Compare
| @@ -0,0 +1,1660 @@ | |||
| #!/bin/bash | |||
| # Copyright 2020 DSR Corporation | |||
There was a problem hiding this comment.
Discussed with Aziz:
It would be better to have a more realistic upgrade test which perform update from 0.12 to 1.2 and then 1.2 to 1.3.
As for test readability, we can still have multiple modules (files) for each version, and the master test will call all the modules one by one.
It's OK to fix it in a separate PR.
Abdulbois
force-pushed
the
#519-Query-PAA-certificate-with-only-subjectKeyId
branch
from
361168a
to
554aa94
Compare
Abdulbois
force-pushed
the
#519-Query-PAA-certificate-with-only-subjectKeyId
branch
13 times, most recently
from
fbca6af
to
d03de3b
Compare
Abdulbois
force-pushed
the
#519-Query-PAA-certificate-with-only-subjectKeyId
branch
5 times, most recently
from
f649fa0
to
c2c9e78
Compare
Enable querying certs with subjectKeyId Add migration flow (from 2 to 3 version of `pki` module) Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com> Signed-off-by: Abdulbois <abdulbois123@gmail.com>
Abdulbois
force-pushed
the
#519-Query-PAA-certificate-with-only-subjectKeyId
branch
from
c2c9e78
to
fa1bd32
Compare
ashcherbakov
approved these changes
Jan 19, 2024
akarabashov
approved these changes
Jan 22, 2024
akarabashov
deleted the
#519-Query-PAA-certificate-with-only-subjectKeyId
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.