Update the NOC root certificate design in accordance with the latest feedback #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashcherbakov
reviewed
Feb 5, 2024
There was a problem hiding this comment.
Please also add/fix the following:
- ADD_NOC_X509_ROOT_CERTIFICATE: remove
vidfield from the parameters (vid will be automatically taken Vendor Accuont's VID value) - Remove command: mention, that child certificates are NOT removed
- Revoke command: add a new optional parameter
revokeChild, false by default. If true, then all children certs (intermediate, lead) are revoked as well. If false - only the current root cert is revoked. - Revoke command: specify what happens if serialNumber is not provided (all certs for Subject+SKID are revoked)
ashcherbakov
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serial_number,info, andtimeoptional fields to theREVOKE_NOC_X509_ROOT_CERTIFICATEtransaction.serial_numberoptional field to theREMOVE_NOC_X509_ROOT_CERTIFICATEtransaction.REMOVE_NOC_X509_ROOT_CERTIFICATEdescription to clarify that deletion also removes revoked certificates.GET_ALL_REVOKED_NOC_X509_ROOT_CERTStransaction.