Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#531 Publish pai certificates for crl signer certificate verification #557

Merged
merged 6 commits into from
Apr 10, 2024
Merged

#531 Publish pai certificates for crl signer certificate verification #557

merged 6 commits into from
Apr 10, 2024

Conversation

Abdulbois
Copy link
Collaborator

  • Add CRLSignerDelegator field into PKI Distribution Point schema
  • Change handling of PKI Distribution Points

@Abdulbois
#531-Publish-PAI-certificates-for-CRLSignerCertificate-verification
d79b7d3 
- Add CRLSignerDelegator field into PKI Distribution Point schema
- Change handling of PKI Distribution Points

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>
Signed-off-by: Abdulbois <abdulbois123@gmail.com>
@Abdulbois Abdulbois force-pushed the #531-Publish-PAI-certificates-for-CRLSignerCertificate-verification branch from df6bd72 to d79b7d3 Compare March 28, 2024 06:32
akarabashov
akarabashov reviewed Mar 28, 2024
View reviewed changes
docs/transactions.md Show resolved Hide resolved
integration_tests/cli/pki-revocation-points.sh Outdated Show resolved Hide resolved
akarabashov
akarabashov reviewed Mar 28, 2024
View reviewed changes
integration_tests/cli/pki-revocation-points.sh Outdated Show resolved Hide resolved
integration_tests/cli/pki-revocation-points.sh Outdated Show resolved Hide resolved
integration_tests/cli/pki-revocation-points.sh Outdated Show resolved Hide resolved
integration_tests/cli/pki-revocation-points.sh Outdated Show resolved Hide resolved
integration_tests/cli/pki-revocation-points.sh Outdated Show resolved Hide resolved
x/pki/handler_add_revocation_test.go Outdated Show resolved Hide resolved
x/pki/handler_update_revocation_test.go Outdated Show resolved Hide resolved
x/pki/handler_add_revocation_test.go Show resolved Hide resolved
x/pki/handler_update_revocation_test.go Show resolved Hide resolved
x/pki/types/message_add_pki_revocation_distribution_point.go Outdated Show resolved Hide resolved
@Abdulbois Abdulbois force-pushed the #531-Publish-PAI-certificates-for-CRLSignerCertificate-verification branch from 3d76b7c to 5e576f4 Compare March 28, 2024 15:12
@Abdulbois
#531-Publish-PAI-certificates-for-CRLSignerCertificate-verification
b24b414 
Minor refactoring due to PR's comments

Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com>
Signed-off-by: Abdulbois <abdulbois123@gmail.com>
@Abdulbois Abdulbois force-pushed the #531-Publish-PAI-certificates-for-CRLSignerCertificate-verification branch from 5e576f4 to b24b414 Compare March 29, 2024 10:17
ashcherbakov
ashcherbakov requested changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@ashcherbakov ashcherbakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • It would be great to ask for test vectors for delegation case from the ticket creators
  • We will need to send a PR back to the spec with the new field crlSignerDelegator.

x/pki/types/message_add_pki_revocation_distribution_point.go Show resolved Hide resolved
x/pki/types/message_add_pki_revocation_distribution_point.go Outdated Show resolved Hide resolved
x/pki/types/message_add_pki_revocation_distribution_point.go Show resolved Hide resolved
x/pki/types/message_add_pki_revocation_distribution_point.go Outdated Show resolved Hide resolved
x/pki/types/message_add_pki_revocation_distribution_point.go Outdated Show resolved Hide resolved
docs/transactions.md Outdated Show resolved Hide resolved
docs/transactions.md Outdated Show resolved Hide resolved
x/pki/keeper/msg_server_update_pki_revocation_distribution_point.go Show resolved Hide resolved
x/pki/keeper/msg_server_update_pki_revocation_distribution_point.go Show resolved Hide resolved
docs/transactions.md Outdated Show resolved Hide resolved
@akarabashov
Merge branch 'master' into #531-Publish-PAI-certificates-for-CRLSigne…
a093608 
…rCertificate-verification

# Conflicts:
#	docs/transactions.md
#	vue/src/store/generated/zigbee-alliance/distributed-compliance-ledger/zigbeealliance.distributedcomplianceledger.pki/module/rest.ts
#	x/pki/types/tx.pb.go
@akarabashov
Fix the transaction proto
cf28090
@akarabashov
Fix the unit test related to CRL signer certificate verification
b9c12cf
@akarabashov akarabashov merged commit 9ad0b95 into master Apr 10, 2024
8 checks passed
@akarabashov akarabashov mentioned this pull request Apr 10, 2024
Closed
@akarabashov akarabashov deleted the #531-Publish-PAI-certificates-for-CRLSignerCertificate-verification branch April 11, 2024 06:31
@tcarmelveilleux tcarmelveilleux mentioned this pull request Apr 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashcherbakov ashcherbakov ashcherbakov approved these changes

@akarabashov akarabashov akarabashov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Abdulbois @ashcherbakov @akarabashov