Set CommissioningModeInitialStepsHint to 1 by default for standard flow #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akarabashov
force-pushed
the
bugfix/522-comissioning-model-initial-step-hints
branch
from
398f85e
to
400dcab
Compare
docs/transactions.md
Outdated
| @@ -260,7 +260,8 @@ All non-edited fields remain the same. | |||
| - productURL: `optional(string)` - URL that contains product specific web page that contains details for the device model. | |||
| - lsfURL: `optional(string)` - URL to the Localized String File of this product. | |||
| - schemaVersion: `optional(uint16)` - Schema version to support backward/forward compatability(default 0) | |||
| - lsfRevision: `optional(uint32)` - LsfRevision is a monotonically increasing positive integer indicating the latest available version of Localized String File. | |||
| - lsfRevision: `optional(uint32)` - LsfRevision is a monotonically increasing positive integer indicating the latest available version of Localized String File. | |||
| - commissioningModeInitialStepsHint: `optional(uint32)` - commissioningModeInitialStepsHint SHALL identify a hint for the steps that can be used to put into commissioning mode a device that has not yet been commissioned. This field is a bitmap with values defined in the Pairing Hint Table. For example, a value of 1 (bit 0 is set) indicates that a device that has not yet been commissioned will enter Commissioning Mode upon a power cycle. | |||
There was a problem hiding this comment.
Should we mention that it can not be updated to zero?
x/model/handler_test.go
Outdated
|
|
||
| // add new model | ||
| msgCreateModel := NewMsgCreateModel(setup.Vendor) | ||
| msgCreateModel.CommissioningModeInitialStepsHint = tc.expectedCommissioningModeInitialStepsHint |
There was a problem hiding this comment.
Suggested change
| msgCreateModel.CommissioningModeInitialStepsHint = tc.expectedCommissioningModeInitialStepsHint | |
| msgCreateModel.CommissioningModeInitialStepsHint = tc.commissioningModeInitialStepsHint |
ashcherbakov
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.