Improve error message texts #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com> Signed-off-by: Abdulbois <abdulbois123@gmail.com>
…ng-NOC-root-certs
Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com> Signed-off-by: Abdulbois <abdulbois123@gmail.com>
# Conflicts: # x/pki/keeper/msg_server_remove_noc_x_509_root_cert.go
akarabashov
reviewed
May 8, 2024
| @@ -55,18 +71,18 @@ func (k msgServer) RemoveNocX509RootCert(goCtx context.Context, msg *types.MsgRe | |||
| k.removeApprovedX509Cert(ctx, certID, &aprCerts, msg.SerialNumber) | |||
There was a problem hiding this comment.
Can we use nocCerts variable instead of aprCerts?
| @@ -64,14 +75,14 @@ func (k msgServer) RemoveNocX509IcaCert(goCtx context.Context, msg *types.MsgRem | |||
| k.removeApprovedX509Cert(ctx, certID, &aprCerts, msg.SerialNumber) | |||
There was a problem hiding this comment.
Can we use icaCerts variable instead of aprCerts?
akarabashov
approved these changes
May 8, 2024
Fix bug related to error messages while removing NOC certificates Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com> Signed-off-by: Abdulbois <abdulbois123@gmail.com>
Abdulbois
force-pushed
the
improve-error-message-texts
branch
from
1f31b92
to
e50f3df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.