Add validation for making Schema Version zero value #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toktar
force-pushed
the
make-schema-version-zero
branch
2 times, most recently
from
49c9613
to
5c9c65b
Compare
Toktar
force-pushed
the
make-schema-version-zero
branch
from
5c9c65b
to
03905dd
Compare
Toktar
force-pushed
the
make-schema-version-zero
branch
from
10ab443
to
34bdf20
Compare
ashcherbakov
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #593 - implementation
Add a (static) validation to all commands (in all tx.proto) so that is the input SchemaVersion != 0, the command is rejected.
TODO:
schemaVersionfield to all Create/Update commands in alltx.protofiles (https://github.com/zigbee-alliance/distributed-compliance-ledger/tree/master/proto/zigbeealliance/distributedcomplianceledger)