Rework initial setup and implement installing specific ZLS version #138
Conversation
Vexu
force-pushed
the
zls-versioning
branch
4 times, most recently
from
1a8d33a
to
47d0527
Compare
Vexu
force-pushed
the
zls-versioning
branch
from
47d0527
to
1c036d7
Compare
|
We just revamped how we do releases and discussed some UX changes we'd like to see on the ZLS front so I'll open a new PR with this new logic in mind. I'd be happy to merge it into this PR / cherry-pick commits / etc. if you'd like, but I think it'll be different enough that it'll be incompatible. Sorry for the trouble. |
Co-authored-by: SuperAuguste <19855629+SuperAuguste@users.noreply.github.com>
src/zls.ts
Outdated
| // compare version triple if commit id is available | ||
| if (version.build.length === 0) { | ||
| // get latest tagged version | ||
| // TODO update when releases are included |
There was a problem hiding this comment.
A latestTagged field would be really nice for this.
There was a problem hiding this comment.
ooo good call
|
I thought I approved this, sorry 😅 This LGTM, though I still need to get the tagged version stuff going on our end. |
|
Thanks, I'll wait for that since being able to install ZLS 0.11.0 is the main point of this change. |
|
So sorry for the delay @Vexu! Updated https://zigtools-releases.nyc3.digitaloceanspaces.com/zls/index.json with the latest info + binaries :) |
|
No worries, I'll fix the remaining issues and try to release an update later today. |
using `globalState` makes it too hard to reset the extension state.
Closes #82
Closes #86
Closes #106
Closes #144