Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch zig.zls.semanticTokens default from partial to full. #205

Closed
wants to merge 1 commit into from
Closed

Switch zig.zls.semanticTokens default from partial to full. #205

wants to merge 1 commit into from

Conversation

alexrp
Copy link
Member

@alexrp alexrp commented May 11, 2024

To align with the ZLS change: zigtools/zls@61b42ca

@Vexu
Copy link
Member

Vexu commented May 11, 2024

The reason that option exist in the first place is for this extension to be able to set it to partial since it provides additional syntax highlighting. zigtools/zls#338

@Vexu Vexu closed this May 11, 2024
@alexrp
Copy link
Member Author

alexrp commented May 11, 2024

That makes sense. Do you think it would be worthwhile to document in the setting that partial will generally give nicer results? That seems unintuitive.

@Vexu
Copy link
Member

Vexu commented May 11, 2024

That I would accept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants