Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use builtin ansi-color-compilation-filter on Emacs >= 28 #69

Merged
merged 2 commits into from
May 21, 2022

Conversation

erikarvstedt
Copy link
Contributor

No description provided.

@erikarvstedt
Copy link
Contributor Author

erikarvstedt commented May 18, 2022

Rationale:
On Emacs >=28, the default way to enable ansi-colors in compilation buffers is to add the new builtin fn ansi-color-compilation-filter to compilation-filter-hook.

Previously, zig-mode forced users to add a custom colorizing fn (colorize-compilation-buffer). In case ansi-color-compilation-filter is already used, this would lead to the ansi-coloring being applied twice (no functional error because it's idempotent).

@joachimschmidt557
Copy link
Member

Thanks!

@joachimschmidt557 joachimschmidt557 merged commit dbc648f into ziglang:master May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants