Consider switching *-uefi-* targets to uefi instead of windows for LLVM 20+
#21630
Labels
backend-llvm
The LLVM backend outputs an LLVM IR Module.
enhancement
Solving this issue will likely involve adding new logic or components to the codebase.
Milestone
Comments
alexrp
added
enhancement
13 tasks
alexrp
added a commit
to alexrp/zig
that referenced
this issue
Nov 28, 2024
Without doing this, we don't actually test whether the data layout string we generate matches LLVM's. A number of targets had to be commented out due to this change: * Some are using a non-working experimental LLVM backend (arc, csky, ...). * Some don't have working LLD support (lanai, sparc, ...). * Some don't have working self-hosted linker support (nvptx). * Some are using ABIs that haven't been standardized (loongarch32). Finally, all non-x86 uefi targets are hopelessly broken and can't really be fixed until we change our emit logic to lower *-uefi-* verbatim rather than to *-windows-*. See: ziglang#21630
alexrp
added a commit
to alexrp/zig
that referenced
this issue
Nov 28, 2024
Without doing this, we don't actually test whether the data layout string we generate matches LLVM's. A number of targets had to be commented out due to this change: * Some are using a non-working experimental LLVM backend (arc, csky, ...). * Some don't have working LLD support (lanai, sparc, ...). * Some don't have working self-hosted linker support (nvptx). * Some are using ABIs that haven't been standardized (loongarch32). Finally, all non-x86 uefi targets are hopelessly broken and can't really be fixed until we change our emit logic to lower *-uefi-* verbatim rather than to *-windows-*. See: ziglang#21630
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is ongoing work to make UEFI a first-class citizen in LLVM. The backend work in particular is what's important for us here.
Once these efforts progress far enough (maybe LLVM 20 or 21?), we should consider switching over to
uefiwhen lowering to LLVM as our use ofwindowsfor this purpose is a brittle hack that could break with any given LLVM upgrade.zig/src/codegen/llvm.zig
Line 186 in ea527f7
The text was updated successfully, but these errors were encountered: