Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make primitive values not keywords #2897

Closed
hryx opened this issue Jul 15, 2019 · 3 comments
Closed

Make primitive values not keywords #2897

hryx opened this issue Jul 15, 2019 · 3 comments
Labels
accepted This proposal is planned. proposal This issue suggests modifications. If it also has the "accepted" label then it is planned.
Milestone
0.11.0

Comments

@hryx
Copy link
Contributor

hryx commented Jul 15, 2019

#1803 was a grammatical cleanup that made all primitive types (anyerror, void, bool) into non-keywords. I think we could do the same for primitive values (true, null, undefined). Types and values are both just values, unlike keywords.

If it's anything like #1803 this will result in deleting code with no downside.
@andrewrk andrewrk added this to the 0.6.0 milestone Jul 15, 2019
@andrewrk andrewrk added accepted This proposal is planned. contributor friendly This issue is limited in scope and/or knowledge of Zig internals. proposal This issue suggests modifications. If it also has the "accepted" label then it is planned. labels Jul 15, 2019
@Vexu Vexu mentioned this issue Jul 21, 2019
Closed
@andrewrk andrewrk removed the accepted This proposal is planned. label Sep 4, 2019
@andrewrk
Copy link
Member

andrewrk commented Sep 4, 2019

I realized there is a downside: #1802

Let's resolve these issues together.

@andrewrk andrewrk added breaking Implementing this issue could cause existing code to no longer compile or have different behavior. and removed contributor friendly This issue is limited in scope and/or knowledge of Zig internals. labels Sep 4, 2019
@andrewrk andrewrk modified the milestones: 0.6.0, 0.7.0 Feb 10, 2020
@andrewrk andrewrk modified the milestones: 0.7.0, 0.8.0 Oct 27, 2020
@andrewrk andrewrk added accepted This proposal is planned. and removed breaking Implementing this issue could cause existing code to no longer compile or have different behavior. labels May 13, 2021
@andrewrk
Copy link
Member

Please see #1802 (comment) for more details here.

@andrewrk andrewrk modified the milestones: 0.8.0, 0.9.0, 0.10.0 May 13, 2021
Snektron added a commit to Snektron/vulkan-zig that referenced this issue Jun 24, 2021
@Snektron
Fix a whole bunch of issues exposed by ziglang/zig#9191
79d901a 
This also includes a workaround for the fact that @"type" refers to the builtin
and not to a variable called "type". See ziglang/zig#2897.
ashpil pushed a commit to ashpil/vulkan-zig that referenced this issue Jun 25, 2021
@Snektron @ashpil
Fix a whole bunch of issues exposed by ziglang/zig#9191
e7af48e 
This also includes a workaround for the fact that @"type" refers to the builtin
and not to a variable called "type". See ziglang/zig#2897.
Snektron added a commit to Snektron/vulkan-zig that referenced this issue Jul 6, 2021
@Snektron
Fix a whole bunch of issues exposed by ziglang/zig#9191
51c16b7 
This also includes a workaround for the fact that @"type" refers to the builtin
and not to a variable called "type". See ziglang/zig#2897.
Snektron added a commit to Snektron/vulkan-zig that referenced this issue Jul 6, 2021
@Snektron
Fix a whole bunch of issues exposed by ziglang/zig#9191
b3c71d6 
This also includes a workaround for the fact that @"type" refers to the builtin
and not to a variable called "type". See ziglang/zig#2897.
@hryx
Copy link
Contributor Author

hryx commented Nov 15, 2022

If I'm not mistaken, this is already done since 05cf449, right?

I back-ported this to C++ in #13343, for what it's worth (probably not much considering the focus on #6378).

@Vexu Vexu closed this as completed Nov 15, 2022
@andrewrk andrewrk modified the milestones: 0.12.0, 0.11.0 Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted This proposal is planned. proposal This issue suggests modifications. If it also has the "accepted" label then it is planned.
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

Make primitive values not keywords Vexu/zig
3 participants
@andrewrk @hryx @Vexu