stage2: add debug info for globals in the LLVM backend #11147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLVM backend: generate DIGlobalVariable's for non-function globals and rename linkage names when exporting functions and globals. zig_llvm.cpp: add some wrappers to convert a handful of DI classes into DINode's since DIGlobalVariable is not a DIScope like the others. zig_llvm.cpp: add some wrappers to allow replacing the LinkageName of DISubprogram and DIGlobalVariable. zig_llvm.cpp: fix DI class mixup causing nonsense reinterpret_cast. The end result is that GDB is now usable since you now no longer need to manually cast every global nor fully qualify every export.
sengir
force-pushed
the
stage2-llvm-dbg-globals
branch
2 times, most recently
from
820d9be to
fe6e767
Compare
|
Excellent work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM backend: generate
DIGlobalVariables for non-function globals andrename linkage names when exporting functions and globals.
zig_llvm.cpp: add some wrappers to convert a handful of DI classesinto
DINodes sinceDIGlobalVariableis not aDIScopelike the others.zig_llvm.cpp: add some wrappers to allow replacing theLinkageNameofDISubprogramandDIGlobalVariable.zig_llvm.cpp: fix DI class mixup causing nonsense reinterpret_cast.The end result is that GDB is now usable since you now no longer need
to manually cast every global nor fully qualify every export.
Closes #11097.