Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: rename @maximum to @max and @minimum to @min #13055

Merged
merged 2 commits into from
Oct 18, 2022

Conversation

alichraghi
Copy link
Contributor

Closes #12994

@andrewrk
Copy link
Member

Please rebase against master branch. Let's get those CI tests passing.

@Vexu
Copy link
Member

Vexu commented Oct 12, 2022

This needs a new Windows CI tarball as does master due to my mistake in #13067

Whoops, looks like the Windows failure wasn't spurious but caused by a need for a new tarball (sigh). #13055 also needs one so maybe these two should be handled together.

I'd build one but zig-bootstrap doesn't work on my machine.

@ominitay
Copy link
Contributor

Seems a minimally useful change, but if it is going ahead, zig fmt should at least fix code. I'm happy to implement that if you don't want to.

@andrewrk
Copy link
Member

andrewrk commented Oct 18, 2022

I suggest that we focus first on replacing stage1 via the C backend before making more breaking changes like this. This will save a lot of time and annoyance of constantly updating the Windows CI tarball, plus it will allow us to start using the new language features in the standard library and compiler codebase, such as inline switch cases.

This will require a few components:

  • async/await/suspend/resume #6025 (started in the stage2-async branch)
  • Many C backend improvements
  • Finish solving the remaining test cases that stage1 is passing and self-hosted is failing, allowing us to fully remove the -fstage1 flag from the compiler (and corresponding logic).

I am focusing on getting 0.10.0 out the door (Nov 1) before doing any of this work.

@Vexu
Copy link
Member

Vexu commented Oct 18, 2022

It would be nice to get this into 0.10.0 since @maximum and @minimum were introduced after 0.9.1

@andrewrk andrewrk merged commit b120c81 into ziglang:master Oct 18, 2022
@andrewrk
Copy link
Member

Making new tarballs now. (These will also include LLVM 15.0.3 which was released today)

@andrewrk
Copy link
Member

It would be nice to get this into 0.10.0 since @maximum and @minimum were introduced after 0.9.1

This is incorrect btw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename @maximum and @minimum to @max and @min
4 participants