Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove -fstage1 option #13383

Closed
wants to merge 1 commit into from
Closed

remove -fstage1 option #13383

wants to merge 1 commit into from

Conversation

andrewrk
Copy link
Member

@andrewrk andrewrk commented Nov 1, 2022

@jedisct1
Copy link
Contributor

jedisct1 commented Nov 1, 2022

#12880 is major issue preventing stage2 from being used when targeting WebAssembly.

@Luukdegram
Copy link
Member

#12880 is major issue preventing stage2 from being used when targeting WebAssembly.

I was unaware of that issue, but I'll happily investigate and fix the issue before this is merged.

@billzez
Copy link
Contributor

billzez commented Nov 1, 2022

Please don't take away stage1 until we can create multi-file modules again:

#13077

I have multiple projects that are blocked by this (and async/await).

@IridescentRose
Copy link
Contributor

IridescentRose commented Nov 1, 2022

Also would like to bring up #12756 where stage2 actually regresses on the abilities of stage1 in terms of comptime assembly. In that thread it was also mentioned that this affects aarch64 and vastly increases the amount of code

@andrewrk
Copy link
Member Author

andrewrk commented Nov 1, 2022

Thanks all - I added more merge blockers in the PR description.

@Luukdegram
Copy link
Member

#12880 is major issue preventing stage2 from being used when targeting WebAssembly.

#13396 :)

After this commit, the self-hosted compiler does not offer the option to
use stage1 as a backend anymore.
@nektro
Copy link
Contributor

nektro commented Nov 15, 2022

#12404 would like this to be added as a blocker please

@andrewrk
Copy link
Member Author

andrewrk commented Dec 6, 2022

Superseded by #13560. We will be temporarily regressing async/await/suspend/resume in master branch.

@andrewrk andrewrk closed this Dec 6, 2022
@andrewrk andrewrk deleted the remove-stage1 branch December 6, 2022 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants