-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std: Optimize functions that deal with bool vectors for x86. #16648
Conversation
No benchmark, but: https://godbolt.org/z/7nqP6zqYr |
This seems to cause some issues with the C backend? Should I add a workaround for that? Or skip the tests for CBE? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your godbolt link shows x86_64 but your logic tests for both x86 and x86_64:
Lines 874 to 879 in 7ab306d
pub inline fn isX86(arch: Arch) bool { | |
return switch (arch) { | |
.x86, .x86_64 => true, | |
else => false, | |
}; | |
} |
Is the new code better for 32-bit x86 as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked this question in the previous review:
Your godbolt link shows x86_64 but your logic tests for both x86 and x86_64:
Is the new code better for 32-bit x86 as well?
I don't see an answer to this question.
The answer is yes. |
Add doc comments. Add tests.
Add doc comments. Add tests.
40ea4b3
to
e131151
Compare
CI checks failing, no updates in 30+ days. |
Add doc comments. Add tests.