Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #19063. this makes
zig fetch
compile and executelib/compiler/fetch.zig
the following refactors were made:
src.introspect.isUpDir
is nowstd.fs.path.isUpDir
.src.introspect
is nowstd.zig.introspect
src.main
'sfindTemplates
,Templates
,findBuildRoot
,BuildRoot
, andFindBuildRootOptions
are all moved intostd.zig.introspect
src.Package
'sFetch
,Manifest
andbuild_zig_basename
are moved intostd.zig.package
. this container name is lowercase as it has no fields.src.Package
still exists. i found movingModule
nontrivial as it depends onCompilation.Config
(which depends onbuild_options
) andZcu.File
. the compromise is an?*anyopaque
onFetch
's .module field. it seems only two pointer casts are needed to make this compile.