musl: Disable warnings in all compilations.
#20921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is what upstream's configure does. Previously, we only disabled warnings in some musl compilations, with `rcrt1.o` notably being one for which we didn't. This resulted in a warning in `dlstart.c` which is included in `rcrt1.c`. So let's just be consistent and disable warnings for all musl code. Closes ziglang#13385.
|
I'd just want to note that after adding |
|
Probably not; the experience will always be bad for users because there's nothing they can actually do about warnings in musl code. And matching upstream musl's warning flags just means we're surfacing the same warnings that upstream will learn of and fix in due time anyway, so it's not clear to me that we gain anything by doing so. |
|
Indeed, fair enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what upstream's configure does: https://git.musl-libc.org/cgit/musl/tree/configure#n537
Previously, we only disabled warnings in some musl compilations, with
rcrt1.onotably being one for which we didn't. This resulted in a warning indlstart.cwhich is included inrcrt1.c. So let's just be consistent and disable warnings for all musl code.Closes #13385.