llvm: Pass EmitOptions to libzigcpp by pointer.
#21251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing it by value means that bringup on new architectures is harder for no real benefit. Passing it by pointer allows to get the compiler running without needing to figure out the C calling convention details first. This manifested in practice on LoongArch, for example.
alexrp
force-pushed
the
la64-c-abi-workaround
branch
from
1039b10
to
1c58320
Compare
|
I applied this patch on my tree https://github.com/yxd-ym/zig-bootstrap/tree/bootstrap-loongarch-2 and now I'm able to bootstrap both Also, these zig binaries of both targets are able to compile simple hello world C program and zig program. |
|
Great, thanks for testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing it by value means that bringup on new architectures is harder for no real benefit. Passing it by pointer allows to get the compiler running without needing to figure out the C calling convention details first. This manifested in practice on LoongArch, for example.
See: ziglang/zig-bootstrap#166 (comment)
The intent here is not to sweep the problem under the rug; I have plans to go through and improve our C calling convention conformance across the board. This just makes initial porting easier.
cc @yxd-ym please test this and see if it gets you unblocked.