Fix cross-compilation to i386-windows-msvc #3434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Mingw's .def files to build a .lib when possible and show an error otherwise.
|
Brilliant. 32 bit windows is now very close to tier 1. I wonder how desirable 32 bit windows binaries would be on the download page. Our current definition of "tier 1" includes having binaries available. However, certainly your recent improvements have made this target tier 1 from a cross compiling perspective. I think it would be simpler for users to keep the current definition, so I'll look into the modifications necessary to add CI support for 32 bit windows. I'm guessing that we'll run out of memory. I think building the std lib tests currently take more than 4GiB memory. The way I was hoping to solve this was with #853 - that is - let stage1 be a ram guzzler but have the self hosted compiler be memory efficient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Mingw's .def files to build a .lib when possible and show an error otherwise.
In other words you now have to supply
.libfiles if you're linking against a non-system (or a system one whose.deffile isn't distributed with Zig yet) library.Fixes the last remaining cross compilation target, don't know what's needed to have it tested on the CI...