Two std.fmt fixes #6360
Merged
Two std.fmt fixes #6360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a regression introduced in ziglang#6246. Adds a test to make sure this won't happen again.
This implementation tries to do the right thing (TM) by treating the
sign as part of the number itself, therefore the alignment parameter
applies to both the sign and the digits.
In other words the format string `{:>4}` with -1 as input will not
output `- 1` but ` -1`.
And let's default to right alignment for everything as that's what users
want, especially when printing numbers. Many implementations use
different defaults for numeric vs non-numeric types, let's strive for a
consistent behaviour here.
daurnimator
added
the
standard library
The two octets in hex notation must be aligned to the right and padded on the left, not the other way around.
data-man
reviewed
Sep 17, 2020
| try testFmt(" true", "{:>10}", .{true}); | ||
| try testFmt("======true", "{:=>10}", .{true}); | ||
| try testFmt("true======", "{:=<10}", .{true}); | ||
| try testFmt(" true ", "{:^10}", .{true}); | ||
| try testFmt("===true===", "{:=^10}", .{true}); | ||
| try testFmt("Minimum width", "{:18} width", .{"Minimum"}); | ||
| try testFmt(" Minimum width", "{:18} width", .{"Minimum"}); | ||
| try testFmt("==================Filled", "{:=>24}", .{"Filled"}); |
There was a problem hiding this comment.
It's not number, why you break it?
There was a problem hiding this comment.
Consistency among data types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the individual commits for more info.