Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler_rt: add __ctzsi2, __ctzdi2 and __ctzti2 #9678

Merged
merged 1 commit into from
Dec 1, 2021
Merged

compiler_rt: add __ctzsi2, __ctzdi2 and __ctzti2 #9678

merged 1 commit into from
Dec 1, 2021

Conversation

matu3ba
Copy link
Contributor

@matu3ba matu3ba commented Sep 2, 2021 

- structure derived from count0bits.zig
- test cases derived from clzsi2_test.zig and
  cross-checked via short helper program

See #1290

@matu3ba
Copy link
Contributor Author

matu3ba commented Sep 2, 2021 •
edited
Loading

Here is the simple helper program to generate (some) expected results https://gist.github.com/matu3ba/a6c0a4fab5d9a8a45db3fc8a7ede2c5c.
Kudos @travisstaloch for making saturation arithmetic/prototyping simple.

@matu3ba matu3ba marked this pull request as ready for review September 3, 2021 07:58
@matu3ba
Copy link
Contributor Author

matu3ba commented Nov 18, 2021 •
edited
Loading

This is ready for merging/review. Azure Windows CI looks super unreliable. Rebased due to deprecation changes.

@matu3ba
compiler_rt: add __ctzsi2, __ctzdi2 and __ctzti2
fb2aa66 
- structure derived from count0bits.zig
- test cases derived from clzsi2_test.zig and
  cross-checked via short helper program

See ziglang#1290
@andrewrk andrewrk merged commit f2608df into ziglang:master Dec 1, 2021
@andrewrk
Copy link
Member

andrewrk commented Dec 1, 2021

Nice work, thank you 👍

@matu3ba matu3ba deleted the crt_ctz branch December 1, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewrk andrewrk andrewrk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matu3ba @andrewrk