Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty Z-Stack build ID in the version response #117

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

puddly
Copy link
Collaborator

@puddly puddly commented Dec 20, 2021

Fixes #116

@codecov-commenter
Copy link

Codecov Report

Merging #117 (8cdcb74) into dev (074f33f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #117   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files          44       44           
  Lines        3873     3876    +3     
=======================================
+ Hits         3824     3827    +3     
  Misses         49       49           
Impacted Files Coverage Δ
zigpy_znp/zigbee/application.py 96.22% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 074f33f...8cdcb74. Read the comment docs.

@puddly puddly merged commit 03ee732 into zigpy:dev Dec 20, 2021
@puddly puddly deleted the puddly/bugfix/handle-empty-zstack-build-id branch December 20, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_zstack_build_id missing ? - '<' not supported between instances of 'NoneType' and 'int'
2 participants