Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use zigpy integer, enum, and bitmap types #225

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

puddly
Copy link
Collaborator

@puddly puddly commented Sep 26, 2023

Zigpy's types at this point have feature parity with zigpy-znp's so it's time to merge the two. This will also allow enum module breaking changes to be handled in a single place.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (e60c556) 98.52% compared to head (8a5bacd) 98.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #225      +/-   ##
==========================================
- Coverage   98.52%   98.07%   -0.45%     
==========================================
  Files          43       43              
  Lines        3787     3694      -93     
==========================================
- Hits         3731     3623     -108     
- Misses         56       71      +15     
Files Coverage Δ
zigpy_znp/commands/af.py 100.00% <100.00%> (ø)
zigpy_znp/commands/app_config.py 100.00% <100.00%> (ø)
zigpy_znp/commands/rpc_error.py 100.00% <100.00%> (ø)
zigpy_znp/commands/sys.py 100.00% <100.00%> (ø)
zigpy_znp/commands/ubl.py 100.00% <100.00%> (ø)
zigpy_znp/commands/util.py 100.00% <100.00%> (ø)
zigpy_znp/commands/zdo.py 100.00% <100.00%> (ø)
zigpy_znp/commands/znp.py 100.00% <100.00%> (ø)
zigpy_znp/types/commands.py 100.00% <100.00%> (ø)
zigpy_znp/types/cstruct.py 100.00% <100.00%> (ø)
... and 5 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant