Support Codecov v4 changes #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Python test failure is unexpected/unrelated. I'll get all other PRs done first and then take a look at this. |
|
Seems to break with zigpy 0.60.3 already. (still taking a look for now) |
|
Ah, you're right. We don't run CI on radio libraries when making zigpy changes and ZNP hasn't needed any since December! Perhaps that would be something to explore in the future. |
|
#246 should fix the test issues. CI won't work on that at all right now, so I'll merge this Codecov PR as-is, then rebase the test fix PR and merge that (and have a green tree again). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT -- do not merge yet (needs below workflow PR merged first, CI will fail for now)Passes the
CODECOV_TOKENGH secret to the shared workflow.Related PR with more information: