Fix blocking metadata version call #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheJulianJES
commented
Jun 14, 2024
| @@ -84,7 +85,7 @@ async def backup_network(znp: ZNP) -> t.JSONType: | |||
|
|
|||
| now = datetime.datetime.now().astimezone() | |||
|
|
|||
| obj["metadata"]["source"] = f"zigpy-znp@{importlib.metadata.version('zigpy-znp')}" | |||
There was a problem hiding this comment.
Ok, we don't really need to replace this in the old CLI tools, but I guess it also doesn't hurt..
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #248 +/- ##
=======================================
Coverage 98.10% 98.10%
=======================================
Files 43 43
Lines 3647 3649 +2
=======================================
+ Hits 3578 3580 +2
Misses 69 69 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the blocking metadata version call outside of the load_network_info coroutine that's run at startup.
And it's also a good test run to see if tests are still working with the latest zigpy.